From: Fillman, Eric (HAL)
Sent: Sunday, July 22, 2012 4:36 PM
To: Guillaume Radde
Cc: Thompson, Sonya (HAL); Ruckman, Maurice (HAL); Augustine, Anila (HAL)
Subject: RE: Chip
Please see below.
Thanks.
-----Original Message-----
From: Guillaume Radde [mailto:guillaume.radde@redhat.com]
Sent: Sunday, July 22, 2012 4:14 PM
To: Fillman, Eric (HAL)
Cc: Thompson, Sonya (HAL); Ruckman, Maurice (HAL); Augustine, Anila (HAL)
Subject: Chip
Eric,
I'm digging into the com.hollandamerica.chip package, and looking at the JiBX mappings. This is part of the modularization work, trying to move the chip related code into a separate module.
Could you confirm that the following statements are correct? Unfortunately, it looks like a lot of this code was written by Jay, but I'm hoping you can help me make sure I understand it correctly:
1) Chip is an XML api for Polar only
In theory, yes. But the word "chip" has incorrectly been translated to be any XML type service processed through WebMethods. But Chip should only be messages to POLAR.
2) All XML messages sent to Polar through chip are buit from the CruiseLineXmlRequest Java object.
They're supposed to be.
3) The following Java classes wrap XML messages to/from Barclays, not Polar, and do not use Chip:
-CCPRequestDTO (Credit Card Process)
-ICRequestDTO (Instant Credit Request)
-PSOfferCaptureRequestDTO (Pre Screen Credit Card Offer)
-PSRequestDTO (Pre Screen a guest for credit card application)
I believe that's correct. When you say "Do not use Chip", I assume you mean they don't go to POLAR through the ChipAPI. But like I said, some people here misinterpret "chip" to be any XML going through WebMethods (like the CCPRequest and the Barclay's messages)
My initial goal was to extract the polar/chip DTOs into a separate chip-connector maven module. I might end up creating several modules at once (one per Third party system we are connecting to):
-chip-connector.jar
-barclays-connector.jar
-steiner-connector.jar
-RTD-connector.jar
OK. Just so you know, when I was doing RTD and knew I'd have to go through WebMethods, I created a WebMethods service (com.hal.sf.service.WebMethodsService) to make the call, rather than using ChipDAO - mainly because I knew it wasn't really Chip. However, the code that WebMethodsService uses is a lot of "chip" code (if you look at it you'll see what I mean). I don't think it's actually uses chip, it's just that the word "chip" is in a lot of the classes and methods used in the WebMethodsService. Unfortunately, I didn't have time to re-factor everything to be non-chip. But if you're going to create separate modules, you might look at using that WebMethodsService and refactoring it to be non-chip.
Thanks!
-------------------------------------
Guillaume Radde
Senior Consultant, Red Hat Consulting
guillaume.radde@redhat.com
http://www.redhat.com
-------------------------------------